-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #123: Add support for string translation for names, descriptions, and messages #141
Merged
TravisCarden
merged 13 commits into
php-tuf:develop
from
TravisCarden:feature/translatable-strings
Jun 9, 2023
Merged
Resolve #123: Add support for string translation for names, descriptions, and messages #141
TravisCarden
merged 13 commits into
php-tuf:develop
from
TravisCarden:feature/translatable-strings
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TravisCarden
force-pushed
the
feature/translatable-strings
branch
from
April 21, 2023 15:13
ba42163
to
a1ca977
Compare
TravisCarden
force-pushed
the
feature/translatable-strings
branch
2 times, most recently
from
April 30, 2023 03:54
643a128
to
6d1cc66
Compare
TravisCarden
force-pushed
the
feature/translatable-strings
branch
6 times, most recently
from
May 9, 2023 05:49
b0654da
to
8693cf0
Compare
TravisCarden
force-pushed
the
feature/translatable-strings
branch
2 times, most recently
from
May 19, 2023 02:55
1c4410c
to
75eff17
Compare
TravisCarden
force-pushed
the
feature/translatable-strings
branch
16 times, most recently
from
May 26, 2023 12:47
609a5bc
to
b9eb44e
Compare
TravisCarden
force-pushed
the
feature/translatable-strings
branch
2 times, most recently
from
May 29, 2023 03:44
c391965
to
8106ebb
Compare
TravisCarden
force-pushed
the
feature/translatable-strings
branch
from
June 1, 2023 04:34
4e7683b
to
12058ca
Compare
effulgentsia
reviewed
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left 2 comments in this review related to making this more compatible with Drupal's translator.
effulgentsia
reviewed
Jun 6, 2023
TravisCarden
force-pushed
the
feature/translatable-strings
branch
3 times, most recently
from
June 8, 2023 17:16
421c420
to
a0564da
Compare
TravisCarden
force-pushed
the
feature/translatable-strings
branch
5 times, most recently
from
June 9, 2023 02:20
a0b80af
to
a6feaf9
Compare
TravisCarden
force-pushed
the
feature/translatable-strings
branch
from
June 9, 2023 03:21
a6feaf9
to
2e25fe5
Compare
TravisCarden
force-pushed
the
feature/translatable-strings
branch
from
June 9, 2023 04:03
2e25fe5
to
14acf04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #123.