Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve #123: Add support for string translation for names, descriptions, and messages #141

Merged

Conversation

TravisCarden
Copy link
Collaborator

Resolves #123.

@TravisCarden TravisCarden force-pushed the feature/translatable-strings branch 2 times, most recently from 643a128 to 6d1cc66 Compare April 30, 2023 03:54
@TravisCarden TravisCarden force-pushed the feature/translatable-strings branch 6 times, most recently from b0654da to 8693cf0 Compare May 9, 2023 05:49
@TravisCarden TravisCarden force-pushed the feature/translatable-strings branch 2 times, most recently from 1c4410c to 75eff17 Compare May 19, 2023 02:55
@TravisCarden TravisCarden force-pushed the feature/translatable-strings branch 16 times, most recently from 609a5bc to b9eb44e Compare May 26, 2023 12:47
@TravisCarden TravisCarden force-pushed the feature/translatable-strings branch 2 times, most recently from c391965 to 8106ebb Compare May 29, 2023 03:44
Copy link

@effulgentsia effulgentsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left 2 comments in this review related to making this more compatible with Drupal's translator.

src/Infrastructure/Service/FileSyncer/PhpFileSyncer.php Outdated Show resolved Hide resolved
@TravisCarden TravisCarden force-pushed the feature/translatable-strings branch 3 times, most recently from 421c420 to a0564da Compare June 8, 2023 17:16
@TravisCarden TravisCarden marked this pull request as ready for review June 9, 2023 04:05
@TravisCarden TravisCarden merged commit 04b730f into php-tuf:develop Jun 9, 2023
7 checks passed
@TravisCarden TravisCarden deleted the feature/translatable-strings branch June 9, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for string translation for names, descriptions, and messages
2 participants