Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PhpFileSyncer and add rsync support for Windows #334

Merged

Conversation

TravisCarden
Copy link
Collaborator

@TravisCarden TravisCarden commented Mar 5, 2024

Fixes #175

This eliminates the need for a whole separate, PHP-based file syncer by refactoring the rsync-based one to support Windows.

BC Breaks:

Everywhere:

  • \PhpTuf\ComposerStager\API\FileSyncer\Service\PhpFileSyncerInterface has been removed.
  • \PhpTuf\ComposerStager\API\FileSyncer\Service\RsyncFileSyncerInterface has been removed.

Windows only:

  • The active and staging directories cannot be on separate volumes.
  • Due to the previous point, the temp directory may cause problems and is no longer tested.
  • The active and staging directories can no longer be nested one inside the other.
  • All paths now use forward slashes.

https://github.com/php-tuf/composer-stager/wiki/Limitations-and-known-issues has been updated accordingly.

@TravisCarden TravisCarden added bug Something isn't working enhancement New feature or request bc break Includes API changes that may require updates in client code labels Mar 5, 2024
@TravisCarden TravisCarden added this to the v2.0.0 milestone Mar 5, 2024
@TravisCarden TravisCarden merged commit b7c1c69 into php-tuf:develop Mar 5, 2024
10 checks passed
@TravisCarden TravisCarden deleted the feature/remove-phpfilesyncer branch March 5, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bc break Includes API changes that may require updates in client code bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory permissions are not correct when using the PHP file syncer
1 participant