Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render to "sub buffers" #128

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Render to "sub buffers" #128

merged 3 commits into from
Nov 16, 2023

Conversation

dantleech
Copy link
Collaborator

  • Do not pass the "render area" to the widget renderers
  • Pass instead a new buffer of the desired size

This apporach simplifies the API but also provides something that we can cache.

dantleech
dantleech commented Nov 16, 2023
View reviewed changes
src/Extension/Core/Widget/BlockRenderer.php
);
$buffer->putBuffer($widget->inner($area)->position, $subBuffer);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe renderers should return the buffer?

@dantleech dantleech merged commit f6adb67 into main Nov 16, 2023
5 checks passed
@dantleech dantleech deleted the sub-buffers branch November 16, 2023 15:47
@dantleech dantleech mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dantleech