Merge pull request #91 from aaa2000/wrong-json-stored-in-casette

Correction of JSON when the file already exists and is blank
php-vcr · Jan 11, 2015 · b145def · b145def
2 parents 0f186ba + 8d9a993
commit b145def
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/VCR/Storage/AbstractStorage.php b/src/VCR/Storage/AbstractStorage.php
@@ -57,7 +57,7 @@ public function __construct($cassettePath, $cassetteName, $defaultContent = '[]'
     {
         $file = $cassettePath . DIRECTORY_SEPARATOR . $cassetteName;
 
-        if (!file_exists($file)) {
+        if (!file_exists($file) || 0 === filesize($file)) {
             file_put_contents($file, $defaultContent);
 
             $this->isNew = true;

diff --git a/tests/VCR/Storage/JsonTest.php b/tests/VCR/Storage/JsonTest.php
@@ -106,6 +106,21 @@ public function testValidJson()
 
     }
 
+    public function testStoreRecordingWhenBlankFileAlreadyExists()
+    {
+        vfsStream::create(array('blank_file_test' => ''));
+        $filePath = vfsStream::url('test/') . 'blank_file_test';
+
+        $jsonObject = new Json(vfsStream::url('test/'), 'blank_file_test');
+        $stored = array(
+            'request' => 'some request',
+            'response' => 'some response'
+        );
+        $jsonObject->storeRecording($stored);
+
+        $this->assertJson(file_get_contents($filePath));
+    }
+
     private function iterateAndTest($json, $expected, $message)
     {
         file_put_contents($this->filePath, $json);