Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Fix code transformation on streams which are divided into several chunks #383

Closed
higidi opened this issue Dec 27, 2022 · 0 comments
Closed

[Backport] Fix code transformation on streams which are divided into several chunks #383

higidi opened this issue Dec 27, 2022 · 0 comments
Assignees
@higidi
Labels
Backport Bug Something isn't working
Milestone
1.5

Comments

@higidi
Copy link
Contributor

higidi commented Dec 27, 2022

Backport of #268 onto the 1.5 branch.
@higidi higidi added Bug Something isn't working Backport labels Dec 27, 2022
@higidi higidi added this to the 1.5 milestone Dec 27, 2022
@higidi higidi self-assigned this Dec 27, 2022
higidi added a commit that referenced this issue Dec 27, 2022
@higidi
FIX: Read the whole stream and perform code transformations
df90936 
First read the whole stream and afterwards perform code transformations.
This will ensure to also replace code, which is divided into chunks while
reading a file.

Fixes #268 and #383

(cherry picked from commit 1917d66)
@higidi higidi mentioned this issue Dec 27, 2022
Merged
@higidi higidi closed this as completed Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@higidi higidi

Labels
Backport Bug Something isn't working
Projects
None yet
Milestone
1.5
Development

When branches are created from issues, their pull requests are automatically linked.

383-backport-fix-code-transformation-on-streams-which-are-divided-into-several-chunks php-vcr/php-vcr
1 participant
@higidi