Add default return value for CURLINFO_CERTINFO #286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
symfony/http-client is using the cURL
CURLINFO_CERTINFO
(see here)However PHP-VCR is not handling this. By default, its value is
[]
, unless a developer use this:What has been done
This PR allows
curl_getinfo($ch, CURLINFO_CERTINFO)
to return the default cURL value :[]
when thosecurl_setopt
are not set, instead of a PHP VCR Exception.How to test
I added a test to
CurlHelperTest
, testing that callingcurl_getinfo($ch, CURLINFO_CERTINFO)
doesn't thrown an exception, but returns the default cURL value.Notes
Build is failing because of PHP CS Fixer on files unrelated to this PR. As multiple PRs include that fix, I didn't run the fix again on this one :)