Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch content type depending on SOAP version. #29

Merged
merged 1 commit into from
Jan 19, 2014

Conversation

kasperg
Copy link
Contributor

@kasperg kasperg commented Jan 16, 2014

SOAP 1.1 uses a different content type than SOAP 1.2 so we should switch
accordingly. Current version assumes 1.2.

SOAP 1.1 uses a different content type than SOAP 1.2 so we should switch
accordingly. Current version assumes 1.2.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) when pulling ddadc19 on kasperg:soap11-support into a68b0f6 on php-vcr:master.

@adri
Copy link
Contributor

adri commented Jan 17, 2014

@kasperg Thank you very much for your pull request. I'd like to add some tests and merge it after. Unfortunately I'm a little short on time... I try to make some time on sunday night.

@kasperg
Copy link
Contributor Author

kasperg commented Jan 17, 2014

Perhaps I can look into adding tests for this as well.

@adri adri mentioned this pull request Jan 19, 2014
@adri adri merged commit ddadc19 into php-vcr:master Jan 19, 2014
@adri
Copy link
Contributor

adri commented Jan 19, 2014

Added tests and merged. Thank you very much @kasperg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants