Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ssl requests in some edge cases like paypal php sdk #334

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

specialtactics
Copy link
Contributor

Context

When using SSL requests, for example with paypal php sdk, it fails to go through vcr properly

What has been done

Added this one option to getCurlOptionFromResponse

How to test

Not exactly sure, but for example the issue for us happens in PayPal\Api\Sale::refundSale()

Notes

Added a define for pre - php 7.3, for the curl constant

@specialtactics
Copy link
Contributor Author

Just a note, the curl constant used only exists as of php 7.3, so I had to do a conditional define for it for php 7.2, and phpstan doesn't pick this up. I read about it on the phpstan wiki, and for this limitation, the best thing is to ignore it, so I added it to the ignore list.

In both cases, I've commented to remove those things once we are no longer supporting php 7.2.

@JeroenVanOort JeroenVanOort merged commit ddabff2 into php-vcr:master Nov 23, 2020
@specialtactics
Copy link
Contributor Author

Thanks for your promptness! Let me know when it's tagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants