Record identical requests #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ette to playback and record request/responses at a given index. Do not require Cassette to manage index state.
… the recording index.
…y exists in the cassette.
… no index keys playback.
…ed cassettes playback multiple identical requests correctly.
…is called as part of eject() and insertCassette().
(with and without legacy entries)
…te have to handle legacy entries Because the Videorecorder increments the index for each identical requests it also passes it to the cassette, so the cassette have to handle legacy stored entries. So if no index is present while loading recorded requests we have to set the index to searched one (instead of zero) to always match (disabled the feature), when all other matchers match.
This reverts commit ce1471b.
dam1r89
reviewed
Feb 3, 2023
|
|
||
| protected function iterateIndex(Request $request): int | ||
| { | ||
| $hash = $request->getHash(); |
There was a problem hiding this comment.
The issue with this method is that it assumes a request is unique based on its hash, but this may not always be the case.
For instance, if someone turns off the header request matcher, requests with the same body, URL, and other parameters but different headers should still be treated as the same request and receive the sequential index.
However, this solution would result in different hashes for those identical requests due to the differing headers, and both would get the same index.
I hope this is clear enough.
Would you accept PR or does this help you to resolve it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is the rebased result of #270 and small fixes and is hopefully the last try to bring this feature back to the
master. There is nothing more to say, for more information see #161 (which inspired #270) or the issue #132.What has been done
TODO