Cleanup: Increase code quality. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lTest::underscoreToLowerCamelcase().
adri
added a commit
that referenced
this pull request
Feb 22, 2014
This PR was merged into php-vcr:master branch. Discussion ---------- Cleanup: Increase code quality. As PHP-VCR gets used more, there is a need for a very stable code which can be easily extended in the future. To ensure good code quality this cleanup will: - [x] Add PHP docblocks - [x] Code coverage > 90% - [x] Move Filters into own namespace - [x] Move Client, SoapClient and Assertion into Util namespace - [x] Try to not hit the network in unit tests (if necessary use a `@group uses_internet`) Fixes #38. Commits ------- 68eaa0a Cleanup: Removes curl library hook using the runkit extension. adri 8253501 Adds comments and tests to Cassette. adri a9231df Fixes loader inclusion for HHVM usage. adri 4b0c943 Cleanup: Moved Client to Util\HttpClient and added tests. adri 184dd45 Cleanup: Commented Cassette class. adri c04ca9a Cleanup: Fixes comment on VCR class. adri 0e63778 Cleanup: Removes VCR_TestCase. adri 4ff6861 Cleanup: Replaces LibraryHooksException with VCRException. adri bab1c1e Cleanup: Moves Util\Soap\SoapClient to Util\SoapClient. adri 70e2cfd Cleanup: Moves SoapClient, adds isEnabled() for library hooks. adri 1d69ca0 Cleanup: Moves all filters to \VCR\Filter namespace, removes FilterInterface. adri 0c9add3 Cleanup: Renames LibraryHookInterface to LibraryHook. adri 8813cc5 Cleanup: Renames StorageInterface to Storage. adri 8ec7e4e Cleanup: Moves Assertion to Util\Assertion. adri 5d30888 Cleanup: Adds documentation to Videorecorder. adri 8f83757 Cleanup: Apply scrutinizer fixes. adri 9452c0a Cleanup: Adds @api annotations to public facing methods of Videorecorder. adri 7372145 Fixed: Do not overwrite tests for filters. adri 1e68e90 Cleanup: Renames handleRequestCallback to requestCallback. adri 51ad106 Cleanup: Scrutinizer codestyle changes. adri 7554688 Cleanup: Removes unnecessary loading of testcase (was deleted). adri a76eef4 Cleanup: Removes obsolete configuration. adri 32c675b Cleanup: Don't mark tests as incomplete which do no assertions. adri 328fa99 Cleanup: Expanded variable names $ch and $fp. adri bd7948b Cleanup: Moved underscore -> lowercamelcase transformation to TextUtilTest::underscoreToLowerCamelcase(). adri ea5c5bc Cleanup: Adds documentation to cURL library hook. adri 1d2d084 Cleanup: Adds SOAP libaryhook constructor docu. adri 55f194e Cleanup: Adds Configuration constructor docu. adri 277c2f5 Cleanup: Documents Response and adds tests. adri 98bbc86 Cleanup: Adds tests for Videorecorder. adri dbfeb8c Cleanup: Ignore cassettes which are created during tests. adri 84e0e28 Cleanup: Disables library hooks when testing eject. adri 080aa6c Cleanup: Adds documentation and tests for Request. adri 4250362 Cleanup: Skips test which needs network connection. adri d83c153 Cleanup: Removes unused dependencies. adri 6127d6b Cleanup: Removes duplicate info in dataproviders for clarity. adri f6b1383 Cleanup: Scrutinizer docblock fixes. adri 1961cba Cleanup: Adds missing property declarations. adri 83ab092 Cleanup: Adds phpunit as dev depencency. adri 6ba210e Cleanup: Removes coveralls from travis config. adri ed0ae8c Cleanup: Renames all library hooks to have 'hook' in the name, like SoapHook, CurlHook, ... adri 02c4929 Fixed: CurlFilter doesn't overwrite method calls to curl-like named methods. adri cf38c60 Implemented: Tests for CurlHook. adri 8f41484 Cleanup: Extracts PROTOCOL constant and adds missing properties in StreamProcessor. adri f5296ff Cleanup: Enables SoapHook test which uses internet (in @group uses_internet). adri 7f88780 Cleanup: Refactors stream_seek() in StreamWrapperHook and adds documentation. adri 33f5152 Fixed: Guzzle integration test. adri 6c9059e Cleanup: Fixes matchBody request matcher and adds test. adri fcac43c Cleanup: Documentes RequestMatcher class. adri f5d318c Cleanup: Adds tests for setStorage and enableRequestMatchers. adri c011d90 Cleanup: Adds test for factory. adri 4ed1c8f Cleanup: Removes --dev flag for composer install in travis. adri 8ab87c5 Cleanup: Set vfsStream to 1.2 version. adri d7d338c Cleanup: Adds documentation to StreamProcessor. adri 1d460c1 Cleanup: Adds test for StreamProcessor. adri e60f25b Cleanup: Fixed docblocks. adri 12d326e Cleanup: Adds tests for StreamWrapperHook::stream_seek(). adri f7e1e6d Cleanup: Removes commented code. adri d7ae224 Cleanup: Skip test in PHP5.3 adri d482257 Fixed: Forwarded right option to fopen. adri 36ebe87 Cleanup: Adds docblocks to CurlHelper. adri aaafc00 Cleanup: Adds docblocks to storage classes. adri 2f7f59e Cleanup: Adds docblock to inherited StreamWrapperHook methods. adri 2e34933 Cleanup: Enabled skipped test. adri 0db2e94 Cleanup: Adds class docblock to Storage interface. adri 29aa4b9 Cleanup: Scrutinizer fixes. adri 772c4a2 Cleanup: Renames Filters to CodeTransform to reflect what it actually does. adri f7a9ce9 Cleanup: Adds docblocks to StreamWrapperHook. adri 0b6eab0 Cleanup: Adds docblocks to StreamProcessor. adri b08b8ce Cleanup: Adds more documentation to StreamProcessor. adri 9be8720 Cleanup: Scrutinizer findings. adri 098e2e3 Cleanup: Adjusts readme and removes commented code. adri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As PHP-VCR gets used more, there is a need for a very stable code which can be easily extended in the future. To ensure good code quality this cleanup will:
@group uses_internet)Fixes #38.