Fixes search and replace across multiple buckets. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adri
force-pushed
the
fix-replace-across-bucket-borders
branch
from
81577b0
to
55c3359
Compare
adri
force-pushed
the
fix-replace-across-bucket-borders
branch
from
1a837af
to
a00920c
Compare
When reading a bucket it might happen that the search string is split up between two buckets and then cannot be found. The (easy) solution is to read in the whole file and then search and replace. Fixes #76.
adri
force-pushed
the
fix-replace-across-bucket-borders
branch
from
a00920c
to
c1a8b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading a bucket it might happen that the search string
is split up between two buckets and then cannot be found.
The (easy) solution is to read in the whole file and then
search and replace.
Fixes #76.