Resolved conflicts with other packages like Phing regarding Exception classes. #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… conflicts with other packages like Phing.
This was referenced Mar 3, 2015
|
I might take both pull requests. Separating classes into separated files is a good practice and it makes sense to add WebDriverException given we don't use namespapce. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix any conflicts of Exception class names with other packages like Phing. #181 attempted to fix this by putting the Exception classes in their own files, this pull request fixes the issue by renaming the Exception class so they all end in "WebDriverException" which makes it more clear what caused the Exception.
I realize that these class names were taken from the the official Java API, but keep in mind that the official Java API uses namespaces (packages) to prevent class name conflicts. As this project does not use namespaces, conflicts have to be reduced by making the class names as unique as possible.