Use Symfony Process component to start local webdriver processes #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in #299, I was unable to start ChromeDriver directly (ie. without Selenium server) and I also have no luck determining the cause (the process got stuck somehow). I was able to fix it by replacing the
proc_open()with Symfony Process component.The Process component itself uses the proc_open(), however, it adds compatibility layer, worarounds for some PHP bugs and encapsulates the whole started process, so it can be easily manipulated (and started asynchronously).
Even though I cannot verify it fixes #299, it makes starting of the process more portable. What do others think?