Add option to specify new window type #833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends creating new window added in #799, so that you can specify intended window type (
tab
orwindow
), as defined in W3C WebDriver spec.It seems more reasonable to have it as part of RemoteTargetLocator (not directly in RemoteWebDriver), similarly as Java bindings does. So lets move the method there and mark the previous one deprecated.
Example:
After merge: