Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the list by YouTube followers count. #61

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

hrsa
Copy link
Collaborator

@hrsa hrsa commented Oct 30, 2023

It works, but it is rather slow, since it uses an external solution (https://yt.lemnoslife.com/channels?handle= ... ) to get youtubers' channel id.

UPD: now its faster and doesn't use any external solutions!

It works, but it is rather slow, since it uses an external solution (https://yt.lemnoslife.com/channels?handle= ... ) to get youtubers' channel id.
@hrsa hrsa requested a review from nunomaduro October 30, 2023 16:16
@Joeri-Abbo
Copy link
Contributor

@hrsa You api token is exposed. Maybe use a dotenv or arg for this so it wont expose the token?
Maybe with python it could be a lot faster with concurrent processing the rows?

@hrsa
Copy link
Collaborator Author

hrsa commented Oct 30, 2023

yep, i just generated a free token for the sake of easily testing that, i'll take it down in a couple of days!

@Joeri-Abbo
Copy link
Contributor

@hrsa Please review my alternative in python it is because of async faster and can be runned on github actions
#62

@Joeri-Abbo
Copy link
Contributor

yep, i just generated a free token for the sake of easily testing that, i'll take it down in a couple of days!

Better safe then sorry in token commits 😄

Anton Cherednichenko and others added 2 commits October 30, 2023 22:54
…nd in the source code of each page, so no need to use external tools to fetch it !
@hrsa hrsa mentioned this pull request Oct 30, 2023
@nunomaduro
Copy link
Contributor

Thanks!

@nunomaduro nunomaduro merged commit bc33f8e into php-youtubers:main Oct 31, 2023
@RVxLab RVxLab mentioned this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants