Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Build documentation on GitHub Actions #2

Closed
wants to merge 1 commit into from

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Dec 30, 2020

This PR

  • builds the documentation on GitHub Actions

πŸ’β€β™‚οΈ The workflow is identical to the one proposed in php/doc-en#299 (except for the LANGUAGE environment variable). You can see this in action at localheinz#1.

@cmb69
Copy link
Contributor

cmb69 commented Dec 30, 2020

Thanks for the PR! Very nice!

You have to clone php/doc-en as well, so you end up with:

de/
doc-base/
en/

Missing files in de are just reused from en.

@localheinz
Copy link
Contributor Author

Thank you, @cmb69 - I adjusted the job accordingly!

@localheinz localheinz marked this pull request as ready for review December 31, 2020 08:47
@localheinz localheinz force-pushed the feature/github-actions branch 13 times, most recently from 2d646c3 to 30aec52 Compare December 31, 2020 17:23
@localheinz localheinz force-pushed the feature/github-actions branch 3 times, most recently from 802b716 to 1cab503 Compare January 8, 2021 17:06
@localheinz
Copy link
Contributor Author

Anything missing here?

@cmb69
Copy link
Contributor

cmb69 commented Jan 24, 2021

Anything missing here?

Yes, the reminder that this PR should be merged. Sorry, complete forgot about it.

@php-pulls php-pulls closed this in a301fcb Jan 24, 2021
@localheinz
Copy link
Contributor Author

Thank you, @cmb69!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants