Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix section order issues #1262

Merged
merged 2 commits into from
Dec 28, 2021
Merged

Fix section order issues #1262

merged 2 commits into from
Dec 28, 2021

Conversation

saundefined
Copy link
Member

Relates #658

@Girgias
Copy link
Member

Girgias commented Dec 27, 2021

I wonder if for destructors we should do the same as constructors and drop the return value section, would need to amend the script for that.

Wdyt @cmb69 ?

@cmb69
Copy link
Contributor

cmb69 commented Dec 27, 2021

I think we should omit the return values section for destructors; if we adapt docgen for that, we should generate <destructorsynopsis> instead of <methodsynopsis>.

@saundefined saundefined merged commit 181e9c5 into php:master Dec 28, 2021
@saundefined saundefined deleted the fix-nits-and-section-order branch December 28, 2021 05:00
tiffany-taylor pushed a commit to tiffany-taylor/doc-en that referenced this pull request Jan 16, 2023
@saundefined @tiffany-taylor
Fix section order issues (php#1262)
fc32d72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@saundefined @Girgias @cmb69