Clarify what NoRewindIterator does #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoRewindIterator does not forbid rewinds, it ignores them.
|
@php-pulls merge |
Firehed
added a commit
to Firehed/doc-en
that referenced
this pull request
Mar 18, 2021
The documented parameters differ from the names exposed in reflection/source code. Now that named parameters are supported in PHP 8, this discrepancy is confusing and impactful.
```
$ php --rf fgetcsv
Function [ <internal:standard> function fgetcsv ] {
- Parameters [5] {
Parameter #0 [ <required> $stream ]
Parameter php#1 [ <optional> ?int $length = null ]
Parameter php#2 [ <optional> string $separator = "," ]
Parameter php#3 [ <optional> string $enclosure = "\"" ]
Parameter php#4 [ <optional> string $escape = "\\" ]
}
- Return [ array|false ]
}
```
php-pulls
pushed a commit
that referenced
this pull request
Mar 18, 2021
The documented parameters differ from the names exposed in reflection/source code. Now that named parameters are supported in PHP 8, this discrepancy is confusing and impactful.
```
$ php --rf fgetcsv
Function [ <internal:standard> function fgetcsv ] {
- Parameters [5] {
Parameter #0 [ <required> $stream ]
Parameter #1 [ <optional> ?int $length = null ]
Parameter #2 [ <optional> string $separator = "," ]
Parameter #3 [ <optional> string $enclosure = "\"" ]
Parameter #4 [ <optional> string $escape = "\\" ]
}
- Return [ array|false ]
}
```
Closes GH-493.
This was referenced May 2, 2022
derickr
added a commit
that referenced
this pull request
Aug 25, 2022
tiffany-taylor
pushed a commit
to tiffany-taylor/doc-en
that referenced
this pull request
Jan 16, 2023
claudepache
pushed a commit
to claudepache/php-doc-en
that referenced
this pull request
Jun 1, 2023
xSavitar
added a commit
to xSavitar/doc-en
that referenced
this pull request
Sep 10, 2023
This patch proposes a fix to something that looks like a typo, supposed to be `public static ...` and not the other way around.
mmalferov
added a commit
to mmalferov/doc-en
that referenced
this pull request
Mar 13, 2024
…ument In strict mode: Fatal error: Uncaught TypeError: var_export(): Argument php#2 ($return) must be of type bool, int given
Girgias
pushed a commit
that referenced
this pull request
Mar 17, 2024
In strict mode: Fatal error: Uncaught TypeError: var_export(): Argument #2 ($return) must be of type bool, int given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoRewindIterator does not forbid rewinds, it ignores them.