Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception updates #238

Closed
wants to merge 8 commits into from
Closed

Exception updates #238

wants to merge 8 commits into from

Conversation

Crell
Copy link
Contributor

@Crell Crell commented Nov 25, 2020

  • Empty catch statements
  • Throw as an expression
  • Various other cleanup while I was there to remove comments

I also deleted a crapload of comments. It's so satisfying.

Girgias
Girgias approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

language/exceptions.xml Show resolved Hide resolved
cmb69
cmb69 reviewed Nov 25, 2020
View reviewed changes
Copy link
Contributor

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Overall very nice work. :)

language/exceptions.xml Outdated Show resolved Hide resolved
language/exceptions.xml Outdated Show resolved Hide resolved
language/exceptions.xml Show resolved Hide resolved
@php-pulls php-pulls closed this in 1d58f72 Nov 25, 2020
@Crell Crell deleted the empty-catch branch November 26, 2020 20:23
@Girgias Girgias mentioned this pull request Jun 9, 2021
Closed
@tiffany-taylor tiffany-taylor mentioned this pull request Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 left review comments

@DaveRandom DaveRandom DaveRandom left review comments

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Crell @cmb69 @DaveRandom @Girgias