New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chapter on Attributes in language section. #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't comment on the general text as I don't really understand the feature, but the usage of you
should be avoided in the docs. So if you could change that that would be great. :)
on declarations in code: Classes, methods, functions, parameters, | ||
properties and constants can be the target of an attribute. The metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add links to the relevant pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be more noise than actually being useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Besides the few nits, I think this is good to be merged. The rest of the documentation updates can be done later.
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
I am not particularly good at documneting things, but this is an acceptable start I hope, for the Attributes feature. it covers the basics:
A bunch of things are missing for now:
Thing
and suchReflectionAttribute
class in reflection bookgetArguments()
methods in every relevant reflection componentafter merging this, doc-base needs a small patch to render this: