Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PhpToken reference #272

Closed
wants to merge 2 commits into from
Closed

Add PhpToken reference #272

wants to merge 2 commits into from

Conversation

jiripudil
Copy link

No description provided.

@cmb69
Copy link
Contributor

cmb69 commented Dec 8, 2020

Very nice, thank you very much! The only change I'm going to apply on top of this is the use of ?string; nullable types should be written as union types; it would be nice, though, if PhD would render them with the question mark.

@php-pulls php-pulls closed this in 82c84a3 Dec 8, 2020
@jiripudil jiripudil deleted the phptoken branch December 9, 2020 07:59
@Girgias Girgias mentioned this pull request Jun 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jiripudil @cmb69 @Girgias