Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output control constants #3039

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Update output control constants #3039

merged 2 commits into from
Dec 27, 2023

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Dec 25, 2023

Added additional section headers above each set of constants to clarify what they are and how to access them, clarified which functions the buffer control flags have an effect on, and added a section for the missing handler status constants.

These last three constants include PHP_OUTPUT_HANDLER_PROCESSED which is returned by ob_get_status() but it is, IMO by mistake, not exposed to userland (PR submitted php/php-src/pull/13019).

The other two, PHP_OUTPUT_HANDLER_STARTED and PHP_OUTPUT_HANDLER_DISABLED, are mentioned as needing documentation in #2747 .

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

reference/outcontrol/constants.xml Outdated Show resolved Hide resolved
@Girgias Girgias merged commit 2ca114b into php:master Dec 27, 2023
2 checks passed
@haszi haszi deleted the output-control-constants-update branch December 29, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants