Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PDORow class to docs #3059

Merged
merged 7 commits into from
Jan 3, 2024
Merged

Add PDORow class to docs #3059

merged 7 commits into from
Jan 3, 2024

Conversation

haszi
Copy link
Contributor

@haszi haszi commented Jan 2, 2024

Add the PDORow class to the docs (#2162) and reference it from the appropriate parts of the PDO docs.

As this class has no methods and all but one the properties of this class are dynamic, I added the description of the class and it's dynamic properties to the introduction section (I've got the idea from stdClass's docs). Let me know whether this format is acceptable.

@Girgias
Copy link
Member

Girgias commented Jan 3, 2024

@kocsismate we should probably have the attribute somehow generated in the class synopsis. don't you think?

@Girgias Girgias added the Extension: pdo All PDO related doc issues label Jan 3, 2024
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. It would be nice to add some more information from https://phpdelusions.net/pdo/fetch_modes#FETCH_LAZY but this can be done later I guess.

reference/pdo/constants.xml Outdated Show resolved Hide resolved
reference/pdo/constants.xml Outdated Show resolved Hide resolved
reference/pdo/pdostatement/fetch.xml Outdated Show resolved Hide resolved
@kamil-tekiela
Copy link
Member

I leave it up to @kocsismate to merge. It looks good to me.

@kocsismate kocsismate merged commit daf4cc6 into php:master Jan 3, 2024
2 checks passed
@haszi haszi deleted the Add-PDORow-to-docs branch January 4, 2024 11:56
@Girgias Girgias mentioned this pull request Jan 5, 2024
32 tasks
@haszi haszi mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extension: pdo All PDO related doc issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants