New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[80999] Fix count TypeError not documented #556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Descending order is used
It might make sense to split the error cases from the example to their own example, and then have three |
@cmb69 is that how you wanted it? Never messes with |
Yes, that's basically what I meant (you can remove the "as of PHP ..." comments now). But it may also make sense to split the example, so that the good cases (the first two |
Should the "bad example" example be after the good example then, or should it be added after the recursive example? Cuz |
I'd put the bad example right after the good example. |
I'm a bit lost on how to "add some words" about the bad example, the title might be enough - I looked around the repo and found a doc using this general idea. Might be OK and get the point across? Otherwise, I'm not sure how to add some words. Can you add notes in or between examples? Those usually go after examples, at least from what I've noticed during my years of looking at the documentation. 馃 |
Thank you very much! |
Glad to help. 馃憤 |
* Add TypeError to changelog * Update example for count to show TypeError * Split example outputs into separate PHP versions * Split examples into good and bad examples Closes php/doc-en#556
This PR adds the TypeError
count()
now throws to the changelog, and also updates the example showing that PHP 8.0 throws a TypeError instead of emitting and E_WARNING.First time adding to a changelog, so not 100% sure if the versions are displayed in descending order or ascending. 馃聽 Will change if requested.