New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection deprecation #578
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azjezz
reviewed
Apr 30, 2021
azjezz
reviewed
Apr 30, 2021
azjezz
reviewed
Apr 30, 2021
thinkverse
reviewed
Apr 30, 2021
thinkverse
reviewed
Apr 30, 2021
cmb69
requested changes
Apr 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments; maybe the build error is related to the <section>
s, but I'm not sure.
reference/reflection/reflectionfunctionabstract/getparameters.xml
Outdated
Show resolved
Hide resolved
Oh, and of course thank you very much for improve the Reflection docs! :) |
cmb69
reviewed
Apr 30, 2021
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
Girgias
reviewed
Apr 30, 2021
reference/reflection/reflectionfunctionabstract/getparameters.xml
Outdated
Show resolved
Hide resolved
cmb69
approved these changes
May 5, 2021
sy-records
approved these changes
May 6, 2021
mumumu
added a commit
to php/doc-ja
that referenced
this pull request
May 6, 2021
* Clarify what a built-in type is. * Add PHP 8 equivalent of ReflectionParameter::isArray(). * Leave note on ReflectionParameter::getClass() for what to use instead. * Clarify order of the array in getParameters(). * Add example to aid working with union types. * Add updated equivalent of isCallable().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considerable chunks of the ReflectionParameter class are marked as deprecated with no indication of what to do instead. After some experimentation (while trying to remove the deprecated stuff from TYPO3), I offer the following "do this instead" options. And some other commentary and improvement along the way.
I'm not 100% sure my XML structuring is right. Let me know what I should do instead and I'll adjust accordingly.