Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection deprecation #578

Merged
merged 11 commits into from May 6, 2021
Merged

Reflection deprecation #578

merged 11 commits into from May 6, 2021

Conversation

Crell
Copy link
Contributor

@Crell Crell commented Apr 30, 2021

Considerable chunks of the ReflectionParameter class are marked as deprecated with no indication of what to do instead. After some experimentation (while trying to remove the deprecated stuff from TYPO3), I offer the following "do this instead" options. And some other commentary and improvement along the way.

I'm not 100% sure my XML structuring is right. Let me know what I should do instead and I'll adjust accordingly.

Copy link
Contributor

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments; maybe the build error is related to the <section>s, but I'm not sure.

reference/reflection/reflectionnamedtype/isbuiltin.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionparameter/getclass.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionparameter/gettype.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionparameter/gettype.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionparameter/isarray.xml Outdated Show resolved Hide resolved
reference/reflection/reflectionparameter/iscallable.xml Outdated Show resolved Hide resolved
@cmb69
Copy link
Contributor

cmb69 commented Apr 30, 2021

Oh, and of course thank you very much for improve the Reflection docs! :)

Crell and others added 2 commits April 30, 2021 15:46
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@Crell Crell requested a review from cmb69 April 30, 2021 21:32
@cmb69 cmb69 merged commit fb5362c into php:master May 6, 2021
mumumu added a commit to php/doc-ja that referenced this pull request May 6, 2021
* Clarify what a built-in type is.
* Add PHP 8 equivalent of ReflectionParameter::isArray().
* Leave note on ReflectionParameter::getClass() for what to use instead.
* Clarify order of the array in getParameters().
* Add example to aid working with union types.
* Add updated equivalent of isCallable().
@Crell Crell deleted the reflection-deprecation branch May 6, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants