locale functions may fail and return null or false
#883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INTL_MAX_LOCALE_LEN limits the length of accepted locale. Anything longer than that will result in a failure and the value returned will either be `null` or `false`. So documentation must reflect that in the return types. This originated from https://bugs.php.net/bug.php?id=81383
|
Return types of all functions are available on https://3v4l.org/1GlnB |
|
Thank you! I've introduced a new XML entity to avoid repetition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INTL_MAX_LOCALE_LEN limits the length of accepted locale. Anything
longer than that will result in a failure and the value returned
will either be
nullorfalse. So documentation must reflect thatin the return types.
This originated from https://bugs.php.net/bug.php?id=81383