Bug #64144: Process failover requests #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UDP support for get requests Support for pipelined requests Multi set/delete/increment/decrement
Improved the benchmark script somewhat
Proper handling of UDP packet loss (reschedule to tcp) Proper handling of request retries Handle network timeouts in select()
Use STREAM_OPEN_PERSISTENT if persistent (correct?) Set UDP retry timeout to same as for tcp
Fixed build with --disable-memcache-session Merged fix for #11221
Added INI directive memcache.hash_function = {crc32, fnv}
Moved "new-style" crc32 stuff into standard_hash strategy
Moved failure callback handling into PHP interface Removed recursion protection in favor of setting the "failed" property on the Memcache object and letting PHP handle freeing the user callback
…o n mirrors New INI directives memcache.redundancy and memcache.session_redundancy
* Continue failover from same point in sequence is multiple failures * Don't failover to server already tried * Distribute redundant keys evenly
Use session redundancy = 2 per default Merged package2.xml from HEAD
…to help the outer requests complete before running themselves
…not cause recursion
Fixed double free under php4 Fixed php6 build
Fixed reference counting on failure callback in php4 versus php5
Added description of new API and INI directives Prepare for release 3.0.0 (alpha)
…on portable api (have to valid other OSes like BSD
…ow) if setSaslData has been called and data has been set correctly
…ename setSaslData to setSaslAuthData to match other interfaces
… making connections failed from time to time
…into NON_BLOCKING_IO * 'NON_BLOCKING_IO' of git.php.net:/pecl/caching/memcache: revert last one, need to refactor this function 1st set stream options before casting to socket to avoid lost of options, making connections failed from time to time add MMC_DEBUG, disabled by default stupid me. remove debug code refactor sasl, fix stupid test code with static user (prev commit), rename setSaslData to setSaslAuthData to match other interfaces rename setSaslData to setSaslAuthData
|
Ooops, PR opened against wrong branch, trying again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the comments at https://bugs.php.net/bug.php?id=64144 for an explanation of why this is necessary. Failover get requests are added to a pool's pending queue, but then are not run until the next memcache API call, by which time the location into which the return value is written is no longer valid. I'm not sure how/if failover get requests have ever worked.
However, I am far from 100% certain that this patch is right, since I do not have a complete understanding of the code.