Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with PHP 8 #14

Merged
merged 2 commits into from Jan 6, 2021
Merged

Fix compatibility with PHP 8 #14

merged 2 commits into from Jan 6, 2021

Conversation

remicollet
Copy link
Contributor

  • cleanup remaining TSRMLS macros
  • fix read/update_property parameters
  • adapt test suite for exception in arg. parsing
  • fix callback

@remicollet
Fix compatibility with PHP 8 - cleanup remaining TSRMLS macros - fix …
13681a7 
…read/update_property parameters - adapt test suite for exception in arg. parsing - fix callback
@remicollet
test on more versions
53ad95d
@remicollet
Copy link
Contributor Author

@laruence can you please have a look, on failing test
As they fail with all version, they probably need to be fixed
but I cannot even open them
So at least if you can convert them to english and set them as XFAIL.

@laruence laruence merged commit 0331a0f into php:php7 Jan 6, 2021
@laruence
Copy link
Member

laruence commented Jan 6, 2021

merged, thanks, I will make some minor cleaup later(after yaf, yaconf, yar, yac php8 supports:<) before I make a new release, thanks

@remicollet
Copy link
Contributor Author

@laruence have you some spare time for this one ?

@remicollet remicollet mentioned this pull request Sep 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@remicollet @laruence