Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"case-sensitive" and "case-insensitive" are easy to mix up #265

Closed
MasterZydra opened this issue Apr 26, 2024 · 3 comments
Closed

"case-sensitive" and "case-insensitive" are easy to mix up #265

MasterZydra opened this issue Apr 26, 2024 · 3 comments

Comments

@MasterZydra
Copy link

MasterZydra commented Apr 26, 2024

Hi,
I am following the specification to implement a PHP lexer.
I noticed that there is a mix of the wording "not case-sensitive" and "case-insensitive".
Would it make sense to just use "not case-sensitive" so that it is more clear?
In my opinion "case-sensitive" and "case-insensitive" is easier to accidentally mix it up.

Examples:

Keywords are not case-sensitive.

automatically available to all scripts; their values are not fixed and they are case-insensitive:

@MasterZydra MasterZydra changed the title "not case-sensitive" and "case-insensitive" are easy to mix up "case-sensitive" and "case-insensitive" are easy to mix up Apr 26, 2024
@Girgias
Copy link
Member

Girgias commented Apr 29, 2024

Using "not case-sensitive" is probably better, but note that this language spec is severely out of date and does not cover any recent changes/additions to the language.

@MasterZydra
Copy link
Author

@Girgias But it is still the official language specification? So I would create a pull request for this change.

@Girgias
Copy link
Member

Girgias commented May 4, 2024

@Girgias But it is still the official language specification? So I would create a pull request for this change.

This language specification is, AFAIK, unmaintained.

From what I seem to remember from things I've been told, this was mainly created by Facebook to come up with some common ground for their implementation of HHVM to be compatible with PHP.

So this is probably only going to be good for parsing requirements up to PHP 7.0 maybe 7.1, and thus you won't have things like readonly, constructor property promotion, union/intersection/DNF types, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants