Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix libxml2 2.12 build due to API breaks
- Loading branch information
Showing
2 changed files
with
11 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0a39890
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be on 8.1 too, just like 6a76e5d
0a39890
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8.1 is security only mode only...
BTW as 6a76e5d was applied, could make sense to also apply 0a39890 and 061058a
0a39890
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or revert the other commit on 8.1. It is misleading for someone to look at the commit history and think that PHP 8.1 supports libxml 2.12.
0a39890
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting would be not good, if there were an issue it should be fixed not reverted.
This commit is not necessary to build php 8.1 with libxml2.12.