Skip to content

Commit

Permalink
Move all testing docs to qa.php.net
Browse files Browse the repository at this point in the history
The qa.php.net currently includes nice collection of information about
tests and how to run them. Instead of maintaining two locations of this
information, this patch removes the README.TESTING from the php-src
repo. Patch for qa.php.net has been sent separately to that repo.
  • Loading branch information
petk committed Oct 18, 2018
1 parent 78a8b0f commit 0e60b81
Show file tree
Hide file tree
Showing 10 changed files with 13 additions and 199 deletions.
2 changes: 1 addition & 1 deletion CODING_STANDARDS
Expand Up @@ -251,7 +251,7 @@ Testing
-------

1. Extensions should be well tested using *.phpt tests. Read about that
in README.TESTING.
at https://qa.php.net/write-test.php.

Documentation and Folding Hooks
-------------------------------
Expand Down
3 changes: 0 additions & 3 deletions CONTRIBUTING.md
Expand Up @@ -52,9 +52,6 @@ We love getting new tests! PHP is a huge project and improving code coverage is
a huge win for every PHP user.

[Our QA site includes a page detailing how to write test cases.](http://qa.php.net/write-test.php)
Please note that the section on submitting pull requests is outdated: in
addition to the process listed there, you can also
[submit pull requests](#pull-requests).

## Writing documentation

Expand Down
9 changes: 4 additions & 5 deletions README.SUBMITTING_PATCH
Expand Up @@ -138,11 +138,10 @@ work on "master".

Read CODING_STANDARDS before you start working.

After modifying the source see README.TESTING and
http://qa.php.net/write-test.php for how to test. Submitting test
scripts helps us to understand what functionality has changed. It is
important for the stability and maintainability of PHP that tests are
comprehensive.
After modifying the source see https://qa.php.net/write-test.php for
how to test. Submitting test scripts helps us to understand what
functionality has changed. It is important for the stability and
maintainability of PHP that tests are comprehensive.

After testing is finished, create a patch file using the command:

Expand Down
181 changes: 0 additions & 181 deletions README.TESTING

This file was deleted.

7 changes: 7 additions & 0 deletions README.md
Expand Up @@ -37,3 +37,10 @@ Guidelines for contributors
- [README.GIT-RULES](/README.GIT-RULES)
- [README.MAILINGLIST_RULES](/README.MAILINGLIST_RULES)
- [README.RELEASE_PROCESS](/README.RELEASE_PROCESS)

## Testing

To run tests the `make test` is used after successful compilation of the sources.

See [Creating new test files](https://qa.php.net/write-test.php) chapter for more
information about testing.
4 changes: 1 addition & 3 deletions ext/exif/tests/exif005.phpt
Expand Up @@ -7,9 +7,7 @@ output_handler=
zlib.output_compression=0
--FILE--
<?php
/* Do not change this test it is a README.TESTING example.
* test5.jpg is a 1*1 image that contains an Exif section with ifd = 00000009h
*/
// test5.jpg is a 1*1 image that contains an Exif section with ifd = 00000009h
$image = exif_read_data(dirname(__FILE__).'/test5.jpg','',true,false);
var_dump($image['IFD0']);
?>
Expand Down
3 changes: 0 additions & 3 deletions ext/sodium/tests/installed.phpt
Expand Up @@ -12,9 +12,6 @@ echo "sodium extension is available";
text in the --EXPECT-- section below for the tests
to pass, differences between the output and the
expected text are interpreted as failure
see php7/README.TESTING for further information on
writing regression tests
*/
?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/standard/tests/strings/str_shuffle.phpt
Expand Up @@ -2,7 +2,6 @@
Testing str_shuffle.
--FILE--
<?php
/* Do not change this test it is a README.TESTING example. */
$s = '123';
var_dump(str_shuffle($s));
var_dump($s);
Expand Down
1 change: 0 additions & 1 deletion ext/standard/tests/strings/strings001.phpt
Expand Up @@ -2,7 +2,6 @@
Test whether strstr() and strrchr() are binary safe.
--FILE--
<?php
/* Do not change this test it is a README.TESTING example. */
$s = "alabala nica".chr(0)."turska panica";
var_dump(strstr($s, "nic"));
var_dump(strrchr($s," nic"));
Expand Down
1 change: 0 additions & 1 deletion ext/standard/tests/strings/strtr.phpt
Expand Up @@ -2,7 +2,6 @@
strtr() function
--FILE--
<?php
/* Do not change this test it is a README.TESTING example. */
$trans = array("hello"=>"hi", "hi"=>"hello", "a"=>"A", "world"=>"planet");
var_dump(strtr("# hi all, I said hello world! #", $trans));
?>
Expand Down

0 comments on commit 0e60b81

Please sign in to comment.