Skip to content

Commit

Permalink
Convert OpenSSL resources to object
Browse files Browse the repository at this point in the history
  • Loading branch information
kocsismate committed Jul 29, 2020
1 parent 9eb7990 commit 2d98cc3
Show file tree
Hide file tree
Showing 37 changed files with 1,083 additions and 764 deletions.
17 changes: 17 additions & 0 deletions UPGRADING
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,23 @@ PHP 8.0 UPGRADE NOTES
. Several alias functions have been marked as deprecated.
. oci_internal_debug() and its alias ociinternaldebug() have been removed.

- OpenSSL:
. openssl_x509_read() and openssl_csr_sign() will now return an
X509Certificate object rather than a resource. Return value checks using
is_resource() should be replaced with checks for `false`.
. The openssl_x509_free() function is deprecated and no longer has an effect,
instead the X509Certificate instance is automatically destroyed if it is no
longer referenced.
. openssl_csr_new() will now return an X509CertificateSigningRequest object
rather than a resource. Return value checks using is_resource() should be
replaced with checks for `false`.
. openssl_pkey_new() will now return an OpenSSLKey object rather than a
resource. Return value checks using is_resource() should be replaced with
checks for `false`.
. The openssl_pkey_free() function is deprecated and no longer has an effect,
instead the OpenSSLKey instance is automatically destroyed if it is no
longer referenced.

- PCRE:
. When passing invalid escape sequences they are no longer interpreted as
literals. This behaviour previously required the X modifier - which is
Expand Down
3 changes: 2 additions & 1 deletion Zend/zend_API.h
Original file line number Diff line number Diff line change
Expand Up @@ -2015,7 +2015,8 @@ static zend_always_inline int zend_parse_arg_str_or_obj(
) {
if (EXPECTED(Z_TYPE_P(arg) == IS_OBJECT)) {
if (base_ce && UNEXPECTED(!instanceof_function(Z_OBJCE_P(arg), base_ce))) {
return 0;
*destination_object = NULL;
return zend_parse_arg_str_slow(arg, destination_string);
}

*destination_string = NULL;
Expand Down
Loading

0 comments on commit 2d98cc3

Please sign in to comment.