Skip to content

Commit

Permalink
ext/curl: Fix failing tests due to string changes in libcurl 8.6.0
Browse files Browse the repository at this point in the history
Upstream libcurl 8.6.0 contains a change[^1] that caused a test failure.
This fixes it by updating the test's `EXPECTF` to use a regex to account for both string patterns.

[^1]: curl/curl@45cf4755e71f#diff-a8a54563608f8155973318f4ddb61d7328dab512b8ff2b5cc48cc76979d4204cL1683

Closes GH-13293.
  • Loading branch information
Ayesh authored and nielsdos committed Jan 31, 2024
1 parent 218a93b commit 4048035
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions NEWS
Expand Up @@ -2,6 +2,8 @@ PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.2.17

- Curl:
. Fix failing tests due to string changes in libcurl 8.6.0. (Ayesh)

15 Feb 2024, PHP 8.2.16

Expand Down
2 changes: 1 addition & 1 deletion ext/curl/tests/bug77946.phpt
Expand Up @@ -34,4 +34,4 @@ curl_multi_close($mh);
--EXPECTF--
int(1)
int(1)
string(%d) "Protocol %Sunknown%S not supported or disabled in libcurl"
string(%d) "Protocol %Sunknown%S %rnot supported( or disabled in libcurl)?%r"

0 comments on commit 4048035

Please sign in to comment.