Skip to content

Commit

Permalink
Address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kocsismate committed Sep 12, 2023
1 parent 04aed09 commit 46aa88b
Show file tree
Hide file tree
Showing 9 changed files with 3,406 additions and 3,414 deletions.
2 changes: 1 addition & 1 deletion ext/readline/tests/bug77812-libedit.phpt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ fclose($pipes[0]);
proc_close($proc);
?>
--EXPECTF--
object(Process)#1 (0) {
object(Standard\Process)#1 (0) {
}
Interactive shell

Expand Down
5 changes: 1 addition & 4 deletions ext/standard/basic_functions.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ PHP_MINIT_FUNCTION(basic) /* {{{ */
assertion_error_ce = register_class_AssertionError(zend_ce_error);

#ifdef PHP_CAN_SUPPORT_PROC_OPEN
process_ce = register_class_Process();
process_ce = register_class_Standard_Process();
php_register_process_class_handlers();
#endif

Expand Down Expand Up @@ -341,9 +341,6 @@ PHP_MINIT_FUNCTION(basic) /* {{{ */
BASIC_MINIT_SUBMODULE(array)
BASIC_MINIT_SUBMODULE(assert)
BASIC_MINIT_SUBMODULE(url_scanner_ex)
#ifdef PHP_CAN_SUPPORT_PROC_OPEN
BASIC_MINIT_SUBMODULE(proc_open)
#endif
BASIC_MINIT_SUBMODULE(exec)

BASIC_MINIT_SUBMODULE(user_streams)
Expand Down
Loading

0 comments on commit 46aa88b

Please sign in to comment.