Skip to content

Commit

Permalink
Mark curl tests using http2.golang.org as XFAIL
Browse files Browse the repository at this point in the history
http2.golang.org/serverpush has been retired[1], so we need to come up
with an alternative.  Until then, we mark the relevant tests as XFAIL
(although bug77535.phpt passes, what might be an indication that the
test needs further revision).  To avoid waiting for the timeout, we
also unconditionally skip these tests for now.

[1] <golang/go#49301>

Closes GH-7829.
  • Loading branch information
cmb69 committed Dec 26, 2021
1 parent e76ddbd commit 5005445
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ext/curl/tests/bug76675.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
--TEST--
Bug #76675 (Segfault with H2 server push write/writeheader handlers)
--XFAIL--
http2.golang.org/serverpush is gone
--SKIPIF--
<?php
include 'skipif.inc';
Expand All @@ -10,6 +12,7 @@ $curl_version = curl_version();
if ($curl_version['version_number'] < 0x073d00) {
exit("skip: test may crash with curl < 7.61.0");
}
die("skip test is slow due to timeout, and XFAILs anyway");
?>
--FILE--
<?php
Expand Down
3 changes: 3 additions & 0 deletions ext/curl/tests/bug77535.phpt
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
--TEST--
Bug #77535 (Invalid callback, h2 server push)
--XFAIL--
http2.golang.org/serverpush is gone
--SKIPIF--
<?php
include 'skipif.inc';
Expand All @@ -10,6 +12,7 @@ $curl_version = curl_version();
if ($curl_version['version_number'] < 0x073d00) {
exit("skip: test may crash with curl < 7.61.0");
}
die("skip test is slow due to timeout, and XFAILs anyway");
?>
--FILE--
<?php
Expand Down

0 comments on commit 5005445

Please sign in to comment.