Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/http2/h2demo: stop running #49301

Closed
dmitshur opened this issue Nov 2, 2021 · 10 comments
Closed

x/net/http2/h2demo: stop running #49301

dmitshur opened this issue Nov 2, 2021 · 10 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Nov 2, 2021 •
edited

The HTTP/2 demo program is currently served at https://http2.golang.org. The index page describes it as:

This server exists for others in the HTTP/2 community to test their HTTP/2 client implementations and point out flaws in our server.

It was created around the time when HTTP/2 support was novel and in active development, eventually being added to the standard library in Go 1.6 in 2016. By now it is still useful but probably significantly less so than it was earlier on.

Though it's sad to say this, I think it has served us well and maybe it's a good time to move on and stop running the HTTP/2 demo server at http2.golang.org, making it easier to focus our attention in other areas that would benefit Go more. (Its source code is public and can always be accessed in the future by anyone interested.)

CC @golang/release, @neild, @bradfitz.
@dmitshur dmitshur added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Nov 2, 2021
@ianlancetaylor
Copy link
Contributor

CC @neild

@gopherbot gopherbot added this to the Unreleased milestone Nov 2, 2021
@neild
Copy link
Contributor

neild commented Nov 2, 2021

SGTM. I don't think the effort of keeping a server running and up-to-date is worth the benefit, and it's easy enough for anyone to run their own local server if they need to test against Go's HTTP/2 implementation.

@heschi heschi added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. labels Nov 3, 2021
@heschi
Copy link
Contributor

heschi commented Nov 3, 2021

I've disabled the alerting and turned off the service. I'll delete the code in a few days if nothing screams.

@heschi heschi self-assigned this Nov 3, 2021
@bradfitz
Copy link
Contributor

bradfitz commented Nov 3, 2021

end of an era :)

@ALTree ALTree mentioned this issue Nov 15, 2021
Closed
@tranb3r
Copy link

tranb3r commented Nov 15, 2021

Would you consider moving the code of https://http2.golang.org/reqinfo to httpbin.org (which seems to be well maintained) ?

@seankhliao
Copy link
Member

httpbin is a python project,
if they wanted to, they're free to take/fork and run the code and run it, no need to move things

@tranb3r
Copy link

tranb3r commented Nov 15, 2021

Sure.
I'm just proposing a way to maintain this test request for clients who need it, without having to maintain your server.
I'll ask httpbin if they can implement a similar request.

@gopherbot
Copy link

Change https://golang.org/cl/364376 mentions this issue: http2/h2demo: delete

@the-mikedavis the-mikedavis mentioned this issue Nov 30, 2021
Closed
cmb69 added a commit to cmb69/php-src that referenced this issue Dec 25, 2021
@cmb69
Mark curl tests using http2.golang.org as XFAIL
147a314 
http2.golang.org/serverpush has been retired[1], so we need to come up
with an alternative.  Until then, we mark the relevant tests as XFAIL
(although bug77535.phpt passes, what might be an indication that the
test needs further revision).

[1] <golang/go#49301>
@cmb69 cmb69 mentioned this issue Dec 25, 2021
Closed
cmb69 added a commit to php/php-src that referenced this issue Dec 26, 2021
@cmb69
Mark curl tests using http2.golang.org as XFAIL
5005445 
http2.golang.org/serverpush has been retired[1], so we need to come up
with an alternative.  Until then, we mark the relevant tests as XFAIL
(although bug77535.phpt passes, what might be an indication that the
test needs further revision).  To avoid waiting for the timeout, we
also unconditionally skip these tests for now.

[1] <golang/go#49301>

Closes GH-7829.
@davecheney davecheney mentioned this issue Mar 8, 2022
Open
@ldemailly
Copy link

QQ where is the source code of the old demo/server? I'm having issues with h2 handler and I would love to see the working code as a comparison to see what I may be doing wrong

@neild
Copy link
Contributor

neild commented May 11, 2022

https://go.googlesource.com/net/+/69e39bad7dc2bbb411fa35755c46020969029fa7/http2/h2demo/ contains the last version prior to deletion.

dteh pushed a commit to dteh/fhttp that referenced this issue Jun 22, 2022
@heschi
http2/h2demo: delete
300be03 
As discussed in golang/go#49301, the service has been shut down. Delete the
source.

Fixes golang/go#49301.

Change-Id: Id987c57d7007d9a75801d1a3a9a229fcd22d69e0
Reviewed-on: https://go-review.googlesource.com/c/net/+/364376
Trust: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@rsc rsc unassigned heschi Jun 23, 2022
@golang golang locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
9 participants
@bradfitz @neild @dmitshur @ianlancetaylor @ldemailly @gopherbot @seankhliao @tranb3r @heschi