Skip to content

Commit

Permalink
fixup! Migrate SOAP SDL resource to object
Browse files Browse the repository at this point in the history
  • Loading branch information
kocsismate committed May 7, 2024
1 parent b273742 commit 66e293f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion UPGRADING
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ PHP 8.4 UPGRADE NOTES
Checks using is_resource() (i.e. is_resource($soapClient->httpurl)) should
be replaced with checks for null (i.e. $soapClient->httpurl !== null).
. SoapClient::$sdl is now a Soap\Sdl object rather than a resource.
Value checks using is_resource() should be replaced with checks for `null`.
Checks using is_resource() (i.e. is_resource($soapClient->sdl)) should be
replaced with checks for null (i.e. $soapClient->sdl !== null).

- SPL:
. Out of bounds accesses in SplFixedArray now throw an exception of type
Expand Down
2 changes: 1 addition & 1 deletion ext/soap/php_soap.h
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ static inline soap_url_object *soap_url_object_fetch(zend_object *obj)

#define Z_SOAP_URL_P(zv) soap_url_object_fetch(Z_OBJ_P(zv))

typedef struct {
typedef struct soap_sdl_object {
sdl *sdl;
zend_object std;
} soap_sdl_object;
Expand Down

0 comments on commit 66e293f

Please sign in to comment.