Skip to content

Commit

Permalink
GNU compilers remove hot attribute proposal. (#8922)
Browse files Browse the repository at this point in the history
While the cold attribute has its place, the hot one however
does one have real justification for use, even more so with
modern toolchains.
  • Loading branch information
devnexen committed Jan 25, 2023
1 parent 48db342 commit 90b0e77
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions Zend/zend_portability.h
Expand Up @@ -265,7 +265,6 @@ char *alloca();

#if defined(__GNUC__) && ZEND_GCC_VERSION >= 4003
# define ZEND_COLD __attribute__((cold))
# define ZEND_HOT __attribute__((hot))
# ifdef __OPTIMIZE__
# define ZEND_OPT_SIZE __attribute__((optimize("Os")))
# define ZEND_OPT_SPEED __attribute__((optimize("Ofast")))
Expand All @@ -275,19 +274,16 @@ char *alloca();
# endif
#else
# define ZEND_COLD
# define ZEND_HOT
# define ZEND_OPT_SIZE
# define ZEND_OPT_SPEED
#endif

#if defined(__GNUC__) && ZEND_GCC_VERSION >= 5000
# define ZEND_ATTRIBUTE_UNUSED_LABEL __attribute__((unused));
# define ZEND_ATTRIBUTE_COLD_LABEL __attribute__((cold));
# define ZEND_ATTRIBUTE_HOT_LABEL __attribute__((hot));
#else
# define ZEND_ATTRIBUTE_UNUSED_LABEL
# define ZEND_ATTRIBUTE_COLD_LABEL
# define ZEND_ATTRIBUTE_HOT_LABEL
#endif

#if defined(__GNUC__) && ZEND_GCC_VERSION >= 3004 && defined(__i386__)
Expand Down

0 comments on commit 90b0e77

Please sign in to comment.