O_APPEND breaks 'c' for DBM files - this is handled

correctly by PHP3, so it's almost a forward'' port :)
php · Jun 13, 2000 · 981e1ae · 981e1ae
1 parent 13692ff
commit 981e1ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/NEWS b/NEWS
@@ -2,6 +2,8 @@ PHP 4.0                                                                    NEWS
 |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 
 ?? ??? 2000, Version 4.0.1
+- Fixed a problem with dbmopen() not handing 'c' correctly with dbm/db/ndbm
+  databases. (JimJag)
 - Fixed an initialization problem in the MS-SQL problem that could cause
   a crash in mssql_query() (Zeev)
 - Upgraded PCRE to version 3.2 and fixed a bug when anchored pattern

diff --git a/ext/db/db.c b/ext/db/db.c
@@ -90,7 +90,7 @@
 #define DBM_TYPE DBM *
 #define DBM_MODE_TYPE int
 #define DBM_WRITE_MODE O_RDWR
-#define DBM_CREATE_MODE O_RDWR | O_APPEND | O_CREAT
+#define DBM_CREATE_MODE O_RDWR | O_CREAT
 #define DBM_NEW_MODE O_RDWR | O_CREAT | O_TRUNC
 #define DBM_DEFAULT_MODE O_RDONLY
 #define DBM_OPEN(filename, mode) dbm_open(filename, mode, 0666)