Convert resources to objects in ext/ldap

php · Mar 14, 2021 · d124f0e · d124f0e
1 parent d4530f8
commit d124f0e
Show file tree

Hide file tree

Showing 38 changed files with 711 additions and 587 deletions.
diff --git a/NEWS b/NEWS
@@ -20,6 +20,11 @@ PHP                                                                        NEWS
   . Implemented FR #68109 (Add MurmurHash V3). (Anatol, Michael)
   . Implemented FR #73385 (Add xxHash support). (Anatol)
 
+- LDAP:
+  . Convert resource<ldap link> to object \LDAP. (Máté)
+  . Convert resource<ldap result> to object \LDAPResult. (Máté)
+  . Convert resource<ldap result entry> to object \LDAPResultEntry. (Máté)
+
 - MySQLi:
   . Fixed bug #70372 (Emulate mysqli_fetch_all() for libmysqlclient). (Nikita)
   . Fixed bug #80330 (Replace language in APIs and source code/docs).

diff --git a/UPGRADING b/UPGRADING
@@ -68,6 +68,17 @@ PHP 8.1 UPGRADE NOTES
   . The IMAP functions now accept and return, respectively, IMAPConnection objects
     instead of resources.
 
+- LDAP:
+  . The LDAP functions now accept and return, respectively, LDAP objects
+    instead of "ldap link" resources. Return value checks using is_resource()
+    should be replaced with checks for `false`.
+  . The LDAP functions now accept and return, respectively, LDAPResult objects
+    instead of "ldap result" resources. Return value checks using is_resource()
+    should be replaced with checks for `false`.
+  . The LDAP functions now accept and return, respectively, LDAPResultEntry
+    objects instead of "ldap result entry" resources. Return value checks using
+    is_resource() should be replaced with checks for `false`.
+
 - MySQLi:
   . mysqli_fetch_fields() and mysqli_fetch_field_direct() will now always return
     zero for max_length. You can compute this information by iterating over the