Skip to content

Commit

Permalink
Give a reason why the test was skipped
Browse files Browse the repository at this point in the history 
A follow up for c93aba0
  • Loading branch information
@carusogabriel
carusogabriel committed Aug 2, 2018
1 parent 6f9ebe6 commit dc4e477
Show file tree
Hide file tree
Showing 17 changed files with 39 additions and 33 deletions.
4 changes: 2 additions & 2 deletions ext/intl/tests/dateformat_set_timezone_id2.phpt
View file
Expand Up @@ -3,8 +3,8 @@ datefmt_set_timezone_id_code() icu >= 4.8
--INI--
date.timezone=Atlantic/Azores
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
<?php if (version_compare(INTL_ICU_VERSION, '50.1.2') >= 0) die('skip for ICU < 50.1.2'); ?>
--FILE--
<?php
Expand Down
5 changes: 3 additions & 2 deletions ext/intl/tests/formatter_format2.phpt
View file
@@ -1,8 +1,9 @@
--TEST--
numfmt_format() icu >= 4.8
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0 || version_compare(INTL_ICU_VERSION, '52.1') >= 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
<?php if (version_compare(INTL_ICU_VERSION, '52.1') >= 0) die('skip for ICU <= 52.1'); ?>
--FILE--
<?php

Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/formatter_format_currency2.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
numfmt_format_currency() icu >= 4.8
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
--FILE--
<?php

Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/formatter_get_set_symbol2.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
numfmt_get/set_symbol() icu >= 4.8
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
<?php if (PHP_INT_SIZE != 8) die('skip 64-bit only'); ?>
--FILE--
<?php
Expand Down
3 changes: 2 additions & 1 deletion ext/intl/tests/intl_icu_data_version_constant.phpt
View file
@@ -1,7 +1,8 @@
--TEST--
INTL_ICU_DATA_VERSION constant
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) || version_compare('INTL_ICU_VERSION', '4.4', '<') ) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare('INTL_ICU_VERSION', '4.4', '<') < 0) print 'skip for ICU > 4.4'; ?>
--FILE--
<?php
var_dump(defined("INTL_ICU_DATA_VERSION"));
Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/locale_filter_matches2.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
locale_filter_matches.phpt() icu >= 4.8 && icu < 50.1.2
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
<?php if (version_compare(INTL_ICU_VERSION, '50.1.2') >= 0) die('skip for ICU < 50.1.2'); ?>
--FILE--
<?php
Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/locale_get_display_name2.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
locale_get_display_name() icu >= 4.8 && icu < 50.1.2
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
<?php if (version_compare(INTL_ICU_VERSION, '50.1.2') >= 0) die('skip for ICU < 50.1.2'); ?>
--FILE--
<?php
Expand Down
6 changes: 3 additions & 3 deletions ext/intl/tests/locale_get_display_region2.phpt
View file
@@ -1,9 +1,9 @@
--TEST--
locale_get_display_region() icu >= 4.8 && icu < 51.2
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
<?php if (version_compare(INTL_ICU_VERSION, '50.1.2') >= 0) die('skip for ICU < 50.1.2'); ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
<?php if (version_compare(INTL_ICU_VERSION, '50.1.2') >= 0) die('skip for ICU <= 50.1.2'); ?>
--FILE--
<?php

Expand Down
5 changes: 3 additions & 2 deletions ext/intl/tests/locale_get_display_script2.phpt
View file
@@ -1,8 +1,9 @@
--TEST--
locale_get_display_script() icu = 4.8
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0 || version_compare(INTL_ICU_VERSION, '49') >= 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
<?php if (version_compare(INTL_ICU_VERSION, '49') >= 0) die('skip for ICU <= 49'); ?>
--FILE--
<?php

Expand Down
5 changes: 3 additions & 2 deletions ext/intl/tests/locale_get_display_script3.phpt
View file
@@ -1,8 +1,9 @@
--TEST--
locale_get_display_script() icu >= 49
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '49') < 0 || version_compare(INTL_ICU_VERSION, '52.1') >= 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '49') < 0) print 'skip for ICU > 49'; ?>
<?php if (version_compare(INTL_ICU_VERSION, '52.1') >= 0) die('skip for ICU <= 52.1'); ?>
--FILE--
<?php

Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/locale_get_display_script4.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
locale_get_display_script() icu >= 52.1
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '52.1') < 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '52.1') < 0) print 'skip for ICU > 52.1'; ?>
--FILE--
<?php

Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/locale_get_display_variant2.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
locale_get_display_variant() icu >= 4.8
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
--FILE--
<?php

Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/locale_parse_locale2.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
locale_parse_locale() icu >= 4.8
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
--FILE--
<?php

Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/msgfmt_fail2.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
msgfmt creation failures icu >= 4.8
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if(version_compare(INTL_ICU_VERSION, '4.8') < 0) print 'skip for ICU > 4.8'; ?>
--FILE--
<?php

Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/normalizer_get_raw_decomposition.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
normalizer_get_raw_decomposition()
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) ) print 'skip'; ?>
<?php if( !function_exists( 'normalizer_get_raw_decomposition' ) ) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' ) ) print 'skip intl extension not loaded'; ?>
<?php if( !function_exists( 'normalizer_get_raw_decomposition' ) ) print 'skip normalizer_get_raw_decomposition function does not exist'; ?>
--FILE--
<?php

Expand Down
4 changes: 2 additions & 2 deletions ext/intl/tests/normalizer_normalize_kc_cf.phpt
View file
@@ -1,8 +1,8 @@
--TEST--
normalize() NFKC_Casefold
--SKIPIF--
<?php if (!extension_loaded('intl')) print 'skip'; ?>
<?php if (!defined('Normalizer::FORM_KC_CF')) print 'skip'; ?>
<?php if (!extension_loaded('intl')) print 'skip intl extension not loaded'; ?>
<?php if (!defined('Normalizer::FORM_KC_CF')) print 'skip Normalizer::FORM_KC_CF constant not defined'; ?>
--FILE--
<?php

Expand Down
4 changes: 3 additions & 1 deletion ext/intl/tests/resourcebundle_internal.phpt
View file
@@ -1,7 +1,9 @@
--TEST--
Test ResourceBundle::__construct() with internal ICU bundles
--SKIPIF--
<?php if( !extension_loaded( 'intl' ) || !defined('INTL_ICU_DATA_VERSION') || version_compare(INTL_ICU_DATA_VERSION, '4.4', '<') ) print 'skip'; ?>
<?php if( !extension_loaded( 'intl' )) print 'skip intl extension not loaded'; ?>
<?php if( !defined('INTL_ICU_DATA_VERSION')) print 'skip INTL_ICU_DATA_VERSION constant not defined'; ?>
<?php if( version_compare(INTL_ICU_DATA_VERSION, '4.4', '<')) print 'skip for ICU > 4.4'; ?>
--FILE--
<?php
$b = new ResourceBundle('de_DE', 'ICUDATA-region');
Expand Down

0 comments on commit dc4e477

Please sign in to comment.