* added --ignore-errors option, --force no longer ignores errors

php · Nov 26, 2002 · df158fa · df158fa
1 parent 58c57d4
commit df158fa
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/pear/PEAR/Command/Install.php b/pear/PEAR/Command/Install.php
@@ -66,6 +66,9 @@ class PEAR_Command_Install extends PEAR_Command_Common
                     'arg' => 'DIR',
                     'doc' => 'root directory used when installing files (ala PHP\'s INSTALL_ROOT)',
                     ),
+                'ignore-errors' => array(
+                    'doc' => 'force install even if there were errors',
+                    ),
                 ),
             'doc' => '<package> ...
 Installs one or more PEAR packages.  You can specify a package to
@@ -117,6 +120,9 @@ class PEAR_Command_Install extends PEAR_Command_Common
                     'arg' => 'DIR',
                     'doc' => 'root directory used when installing files (ala PHP\'s INSTALL_ROOT)',
                     ),
+                'ignore-errors' => array(
+                    'doc' => 'force install even if there were errors',
+                    ),
                 ),
             'doc' => '<package> ...
 Upgrades one or more PEAR packages.  See documentation for the
@@ -154,6 +160,9 @@ class PEAR_Command_Install extends PEAR_Command_Common
                     'arg' => 'DIR',
                     'doc' => 'root directory used when installing files (ala PHP\'s INSTALL_ROOT)',
                     ),
+                'ignore-errors' => array(
+                    'doc' => 'force install even if there were errors',
+                    ),
                 ),
             'doc' => '
 Upgrades all packages that have a newer release available.  Upgrades are
@@ -179,6 +188,9 @@ class PEAR_Command_Install extends PEAR_Command_Common
                     'arg' => 'DIR',
                     'doc' => 'root directory used when installing files (ala PHP\'s INSTALL_ROOT)',
                     ),
+                'ignore-errors' => array(
+                    'doc' => 'force install even if there were errors',
+                    ),
                 ),
             'doc' => '<package> ...
 Uninstalls one or more PEAR packages.  More than one package may be

diff --git a/pear/PEAR/Installer.php b/pear/PEAR/Installer.php
@@ -220,8 +220,8 @@ function _installFile($file, $atts, $tmp_path)
             $this->log(3, "+ mkdir $dest_dir");
         }
         if (empty($atts['replacements'])) {
-            if (!copy($orig_file, $dest_file)) {
-                return $this->raiseError("failed to copy $orig_file to $dest_file",
+            if (!@copy($orig_file, $dest_file)) {
+                return $this->raiseError("failed to write $dest_file",
                                          PEAR_INSTALLER_FAILED);
             }
             $this->log(3, "+ cp $orig_file $dest_file");
@@ -684,7 +684,7 @@ function install($pkgfile, $options = array())
                 $res = $this->_installFile($file, $atts, $tmp_path);
                 $this->popExpect();
                 if (PEAR::isError($res)) {
-                    if (empty($options['force'])) {
+                    if (empty($options['ignore-errors'])) {
                         $this->rollbackFileTransaction();
                         return $this->raiseError($res);
                     } else {

diff --git a/pear/package-PEAR.xml b/pear/package-PEAR.xml
@@ -35,9 +35,12 @@
     <state>stable</state>
     <date>2002-11-11</date>
     <notes>
-New Features, Installer:
-* installer aborts failed installs nicely (using
-  file "transactions")
+Changes, Installer:
+* --force option no longer ignores errors, use
+  --ignore-errors instead
+* installer transactions: failed installs abort
+  cleanly, without leaving half-installed packages
+  around
 </notes>
     <filelist>
       <file role="data" name="package.dtd"/>