Mark parameter in ext/odbc as sensitive

php · Jun 13, 2022 · e85b17b · e85b17b
1 parent ac6dbbd
commit e85b17b
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 3 deletions.
diff --git a/ext/odbc/odbc.stub.php b/ext/odbc/odbc.stub.php
@@ -69,10 +69,16 @@ function odbc_result_all($statement, string $format = ""): int|false {}
 /** @param resource $statement */
 function odbc_free_result($statement): bool {}
 
-/** @return resource|false */
+/**
+ * @sensitive-param $password
+ * @return resource|false
+ */
 function odbc_connect(string $dsn, string $user, string $password, int $cursor_option = SQL_CUR_USE_DRIVER) {}
 
-/** @return resource|false */
+/**
+ * @sensitive-param $password
+ * @return resource|false
+ */
 function odbc_pconnect(string $dsn, string $user, string $password, int $cursor_option = SQL_CUR_USE_DRIVER) {}
 
 /** @param resource $odbc */

diff --git a/ext/odbc/odbc_arginfo.h b/ext/odbc/odbc_arginfo.h
diff --git a/ext/odbc/php_odbc.c b/ext/odbc/php_odbc.c
@@ -24,6 +24,7 @@
 
 #include "php.h"
 #include "php_globals.h"
+#include "zend_attributes.h"
 
 #include "ext/standard/info.h"
 #include "ext/standard/php_string.h"
@@ -483,6 +484,8 @@ PHP_MINIT_FUNCTION(odbc)
 	putenv("DB2NOEXITLIST=TRUE");
 #endif
 
+	register_odbc_symbols(module_number);
+
 	return SUCCESS;
 }
 /* }}} */