Skip to content

Commit

Permalink
Add MB_ONIGURUMA_VERSION and use it in a version dependent test
Browse files Browse the repository at this point in the history
  • Loading branch information
nikic committed Feb 11, 2019
1 parent d1c1481 commit e91d8ac
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions ext/mbstring/php_mbregex.c
Expand Up @@ -105,7 +105,13 @@ void php_mb_regex_globals_free(zend_mb_regex_globals *pglobals)
/* {{{ PHP_MINIT_FUNCTION(mb_regex) */
PHP_MINIT_FUNCTION(mb_regex)
{
char version[256];

onig_init();

snprintf(version, sizeof(version), "%d.%d.%d",
ONIGURUMA_VERSION_MAJOR, ONIGURUMA_VERSION_MINOR, ONIGURUMA_VERSION_TEENY);
REGISTER_STRING_CONSTANT("MB_ONIGURUMA_VERSION", version, CONST_CS | CONST_PERSISTENT);
return SUCCESS;
}
/* }}} */
Expand Down
1 change: 1 addition & 0 deletions ext/mbstring/tests/mb_ereg_variation3.phpt
Expand Up @@ -4,6 +4,7 @@ Test mb_ereg() function : usage variations - pass different character classes to
<?php
extension_loaded('mbstring') or die('skip');
function_exists('mb_ereg') or die("skip mb_ereg() is not available in this build");
version_compare(MB_ONIGURUMA_VERSION, '6.1.0', '>=') or die("skip requires oniguruma >= 6.1.0");
?>
--FILE--
<?php
Expand Down

0 comments on commit e91d8ac

Please sign in to comment.