Mark parameter in ext/ftp as sensitive

php · Jun 13, 2022 · f9fa6d0 · f9fa6d0
1 parent 0d4147f
commit f9fa6d0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/ext/ftp/ftp.stub.php b/ext/ftp/ftp.stub.php
@@ -75,6 +75,7 @@ function ftp_connect(string $hostname, int $port = 21, int $timeout = 90): FTP\C
     function ftp_ssl_connect(string $hostname, int $port = 21, int $timeout = 90): FTP\Connection|false {}
     #endif
 
+    /** @sensitive-param $password */
     function ftp_login(FTP\Connection $ftp, string $username, string $password): bool {}
     function ftp_pwd(FTP\Connection $ftp): string|false {}
     function ftp_cdup(FTP\Connection $ftp): bool {}

diff --git a/ext/ftp/ftp_arginfo.h b/ext/ftp/ftp_arginfo.h
diff --git a/ext/ftp/php_ftp.c b/ext/ftp/php_ftp.c
@@ -29,6 +29,7 @@
 
 #include "ext/standard/info.h"
 #include "ext/standard/file.h"
+#include "Zend/zend_attributes.h"
 #include "Zend/zend_exceptions.h"
 
 #include "php_ftp.h"