-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing tests with external libgd #11252
Comments
It looks like |
I've got another PR in the works fixing the rest of the ones that I know how to fix. If, in addition, I patch
Here's my best guess as to what's happening. Fail due to changes made in https://svn.php.net/viewvc/?view=revision&revision=286415 that never went upstream:
Unsure. The bug was fixed in #1845 and it looks like the changes should have gone upstream, but the test still reports different sizes:
This one segfaults(?):
And finally, this fails because of a minor size difference (expected 135x136, got 137x137), and is probably due to the same imagerotate/boxing issues elsewhere:
@pierrejoye your input would be helpful on the difference between the bundled and upstream results, or anywhere really :) |
And here's the last PR: #11280 |
IIRC the only remaining failures are the six mentioned in #11252 (comment) whose causes are so far unknown. Should I leave this open, or close it and open a new issue with the more limited scope of fixing those six? |
Description
I was experimenting with using the system gd for our Gentoo package, and noticed a bunch of test failures:
These fall into a few classes, some more difficult than others.
bug45799.phpt
is looking forWarning: imagepng(): gd-png error: no colors in palette in %s on line %d
but getsWarning: imagepng(): gd-png error: no colors in palette\n in %s on line %d
. These tests could be made to support both outputs.PHP Version
git master
Operating System
No response
The text was updated successfully, but these errors were encountered: