Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault in hash_copy() on a finalized context #12186

Closed
MaxSem opened this issue Sep 12, 2023 · 0 comments
Closed

Segfault in hash_copy() on a finalized context #12186

MaxSem opened this issue Sep 12, 2023 · 0 comments
Labels
Bug Extension: hash Status: Verified

Comments

@MaxSem
Copy link
Contributor

MaxSem commented Sep 12, 2023 •
edited by Girgias

Description

The following code:

https://3v4l.org/AdgqN

<?php
$c = hash_init('sha1');
hash_final($c);
hash_copy($c);

Resulted in this output:

Segmentation fault

Same thing happens when the context is cloned. Reproducible with multiple algos, though not checked them all.

PHP Version

PHP 8.0+

Operating System

No response
MaxSem added a commit to MaxSem/php-src that referenced this issue Sep 12, 2023
@MaxSem
Fix phpGH-12186: segfault copying/cloning a finalized HashContext
95cd40c 
Closes php#12186
This was referenced Sep 12, 2023
Closed
Open
MaxSem added a commit to MaxSem/php-src that referenced this issue Sep 12, 2023
@MaxSem
Fix phpGH-12186: segfault copying/cloning a finalized HashContext
af9a4a7 
Closes php#12186
MaxSem added a commit to MaxSem/php-src that referenced this issue Sep 13, 2023
@MaxSem
Fix phpGH-12186: segfault copying/cloning a finalized HashContext
18f4cdc 
Closes php#12186
nielsdos added a commit that referenced this issue Sep 16, 2023
@nielsdos
Merge branch 'PHP-8.1' into PHP-8.2
5df473d 
* PHP-8.1:
  Fix GH-12223: Entity reference produces infinite loop in var_dump/print_r
  Fix GH-12192: SimpleXML infinite loop when getName() is called within foreach
  Fix GH-12186: segfault copying/cloning a finalized HashContext
nielsdos added a commit that referenced this issue Sep 16, 2023
@nielsdos
Merge branch 'PHP-8.2' into PHP-8.3
4bb27e2 
* PHP-8.2:
  Fix GH-12223: Entity reference produces infinite loop in var_dump/print_r
  Fix GH-12192: SimpleXML infinite loop when getName() is called within foreach
  Fix GH-12186: segfault copying/cloning a finalized HashContext
nielsdos added a commit that referenced this issue Sep 16, 2023
@nielsdos
Merge branch 'PHP-8.3'
fad0e4f 
* PHP-8.3:
  Fix GH-12223: Entity reference produces infinite loop in var_dump/print_r
  Fix GH-12192: SimpleXML infinite loop when getName() is called within foreach
  Fix GH-12186: segfault copying/cloning a finalized HashContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Extension: hash Status: Verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix GH-12186: segfault copying/cloning a finalized HashContext MaxSem/php-src
3 participants
@MaxSem @Girgias @damianwadley