SimpleXMLElement with stream_wrapper_register can segfault

[mvorisek]

Description

repro: https://3v4l.org/sR5ZB

inspired by #12926 and https://github.com/php/php-src/pull/12546/files

SimpleXMLIterator , SodiumException, IntlChar have the same issue

because of https://github.com/php/php-src/blob/php-8.3.0/run-tests.php#L2077 the run-tests.php test should be improved to allow to specify something like * in EXTENSIONS section, as currently the https://github.com/php/php-src/pull/12546/files is not really tested with all ext

PHP Version

8.1.0 - 8.1.7, 8.3.0

Operating System

any

[nielsdos]

Can confirm, at least for SimpleXML it's because in 8.3 I added the invalidation code which accesses node->doc but apparently node can be NULL after GET_NODE because that macro doesn't perform the return...
The locations of GET_NODE have to be checked on 8.2+.

[nielsdos]

SodiumException, IntlChar have the same issue

I can't reproduce it for these two classes though, not on my local machine and not in 3v4l...

Anyway PR is up to fix SimpleXML.

[mvorisek]

SodiumException, IntlChar have the same issue

I can't reproduce it for these two classes though, not on my local machine and not in 3v4l...

3v4l repro: https://3v4l.org/pDpKO

[nielsdos]

3v4l repro: https://3v4l.org/pDpKO

But that doesn't segfault/crash right? https://3v4l.org/shafO I added a var_dump at the end and it prints, I don't see a code 139.

[mvorisek]

I can confirm this is present for the XML classes only, at least today :)