Fix bug #25215: max_input_time timeout misreported #1010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change PHP uses a different error message upon running into a timeout when it relates to max_input_type instead of max_execution_time.
| @@ -208,6 +211,7 @@ struct _zend_executor_globals { | |||
|
|
|||
| /* timeout support */ | |||
| zend_long timeout_seconds; | |||
| int timeout_type; | |||
There was a problem hiding this comment.
I'd prefer using an unsigned char here. More appropriate storage size
|
@jpauli, thanks for your feedback. I've changed the variable type. |
|
@mj can you please rebase this to fix merge conflicts ? (on a side note, use I'm not sure why this wasn't merged, looks like a nice improvement that can go in master when it's fixed. |
|
Unbelievably this was requested more than 10 years ago (2003): https://bugs.php.net/bug.php?id=25215 |
|
Having waited more than a month for feedback, and having received nothing, I'm closing this PR as it would appear abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change PHP uses a different error message upon running into a timeout when it relates to max_input_type instead of max_execution_time.
I'm having a hard time coming with a test case for this, unfortunately.