php.ini: set variables_order to EGPCS #10182
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
heyho,
during development i encountered some issues with $_ENV and cli scripts invoked like this:
which was odd, because on my debian box this worked fine but on a macos install via homebrew it was not working. we noticed that variables_order was set to
GPCS
and thus ommitting the $_ENV superglobal i required to have theCONFIG_TARGET
set.after some digging around, i found the formular for php on homebrew with its source for the default configuration:
https://github.com/Homebrew/homebrew-core/blob/56299f3dac37eaf9fe0b1e187b889f559a74be26/Formula/php.rb#L219
the default for the
variables_order
is defined asECPGS
in the documentation but both thephp.ini-production
andphp.ini-development
had those set toGPCS
which contradicts the docs.the current dockerhub image also uses EGPCS as a sane default
so i figured the right thing to do is to update both php.ini files according to the documentation.